Add sparse block diagonal matrices #1225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI errors are going to be fixed by Nemocas/AbstractAlgebra.jl#1448 and are independent of the changes here. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1225 +/- ##
==========================================
- Coverage 74.54% 74.41% -0.13%
==========================================
Files 346 346
Lines 110806 110830 +24
==========================================
- Hits 82596 82477 -119
- Misses 28210 28353 +143
☔ View full report in Codecov by Sentry. |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for oscar-system/Oscar.jl#2844. I started with the method in AbstractAlgebra and tried to adapt it as best as possible.